awahab07
commented
2 years ago Post FF Testing
LGTM
- Does respect the location for monitor-with-locations when listing last successful check.
- Doesn't list last successful check for a failed step with no prior successful steps.
- Correctly shows the last successful screenshot and links to last successful step.
Monitors with locations (Used oblt-edge for testing)
- A successful ping on 1:34:24 PM with first step timestamped at 1:34:13 PM with location spa shows only one (successful) screenshot.
- The same monitor fails for the same location (spa) on the next ping (1:35:24 PM). Notice that there are other successful pings for the same monitor for different locations, in between the last successful spa- and failed spa- ping.
- The failed step shows two screenshots, the failed one and the last successful one from step 1 above with a link to the "last successful check". The last successful check is from the same location although there were more recent successful steps from other locations.
- "the last successful" link correctly takes to the last successful step for the same location.
Monitors without locations
- Successful step shown on one (successful) screenshot.
- A failed step doesn't show a "last successful check" screenshot if there's no prior successful check.
- Notice the failed step at 5:18:49 PM, it should mention the step at 5:16:49 PM as "last successful check".
- It correctly includes and links the last successful check screenshot.
When a step fails and we show the screenshot of the last successful check as a comparison to the failure, it does so using the screenshot of the most recent successful test prior to the failure.
However, when tests for the same monitor are running from multiple locations, the screenshot we show will be the most recent (prior to the failure) regardless of location.
It’s not uncommon for websites to deliver different content based on the location of the client. As such, the most recent good image (for comparison) should only be shown from test results from the same location.
In fact, if there are no previous good tests from this location, then no comparison image should be shown (even if there is a good test from a different location), as it’s a misleading comparison.