elastic / uptime

This project includes resources and general issue tracking for the Elastic Uptime solution
12 stars 3 forks source link

[Uptime] Show inline errors on Monitor Management #439

Closed paulb-elastic closed 2 years ago

paulb-elastic commented 2 years ago

This is the inline error version of those we'll be adding for suites in https://github.com/elastic/uptime/issues/438.

This depends on https://github.com/elastic/beats/issues/29897.

As a Synthetics Service User I want to clearly see if my inline script has a problems (syntax error) that is preventing the monitor from running So that I quickly debug the issue to a resolution and get the monitor working

ACs:

Example layout adding to the main Monitor Management table: image

shahzad31 commented 2 years ago

@paulb-elastic @drewpost i am bit confused what's the scope of errors here. Do we display errors when journey can't even start, or any error will appear here?

drewpost commented 2 years ago

I think the wording is confusing. This page is meant to only show an error if it's related to monitor config (in this case a syntax error in an inline script). It does NOT show the status of test runs.

The confusing part is mentioning showing the same errors as on the overview page. What this means is that if a monitor is unable to run because of an error, we want to tell users of that on the overview page too. We want that status to be consistent between the two pages.

Is that a correct understanding @paulb-elastic ?

paulb-elastic commented 2 years ago

Apologies for any confusion. Correct @drewpost, this is to show users when there is a problem with the monitor configuration (script code), which means it cannot run (i.e. we are unable to determine if the site under test is UP or DOWN). It is not meant to reflect the status of the monitor (UP or DOWN).

The reference to …the same errors as on the overview page which may have caused confusion, was referring to the way (UX) we are displaying these on the other page: image

Does that help clear it up?