elastic / uptime

This project includes resources and general issue tracking for the Elastic Uptime solution
12 stars 3 forks source link

Move UX server side code out of APM UI #454

Closed shahzad31 closed 2 years ago

shahzad31 commented 2 years ago

We still have node server side code in the APM UI for user experience app, we need to move that out of APM UI.

This is a follow up to https://github.com/elastic/kibana/issues/78430

There are two approaches that will be taken to accomplish this.

User exploratory view to replace charts, this will auto remove server side routes and will make charts completely client side.

In cases where we can't use exploratory view, we should use async search api to make calls to Elasticsearch.

EDIT by @justinkambic:

Areas of focus

Additional items:

paulb-elastic commented 2 years ago

Pushing to 8.3, and the expectation is that the simplest implementation is done for this to get out of the APM UI codebase

paulb-elastic commented 2 years ago

Moving to 8.4 as these PRs are not being merged on for 8.3

emilioalvap commented 2 years ago

@shahzad31 @justinkambic Checking percentile component, it seems to be statically declared inside the UX plugin. Can we remove that from the task list or is there anything else that needs migrating here?

paulb-elastic commented 2 years ago

Mostly done but moving over to 8.5 board where the last remaining item https://github.com/elastic/kibana/pull/135367 will be targeted for.

emilioalvap commented 2 years ago

Marking as done, last PR was merged into 8.5

dominiqueclarke commented 2 years ago

POST FF Testing:

Did general smoke tests of the UX page on 8.5 local branch via data from oblt-cli.

Looks great, generally, but the browser breakdown and operating system breakdown appears to be broken.

Screen Shot 2022-09-28 at 3 46 16 PM

cc: @justinkambic @emilioalvap

paulb-elastic commented 2 years ago

Reopening as per @dominiqueclarke's discovery

emilioalvap commented 2 years ago

Fixed by elastic/kibana#142992.

Moving to Done Done, as @shahzad31 and I have validated it.