search

elasticdog / puppet-sandbox

A Vagrant-based Puppet development environment for creating new modules
MIT License
218 stars 100 forks source link

Vagrantfile adapted to work with Vagrant 1.1+ #5

Closed ganguera closed 11 years ago

ganguera commented 11 years ago

Hi folks!

I was trying to run puppet-sandbox with the latest Vagrant release (1.1) and it wasn't working because it introduces some different configuration objects (http://docs.vagrantup.com/v2/vagrantfile/version.html).

I adapted the Vagrantfile to work with Vagrant 1.1+ but obviously I broke the backward compatibility (<=1.0) wich in fact, it was already broken.

Looking forward to hearing from you.

phinze commented 11 years ago

I did pretty much the same thing locally when I updated to vagrant 1.1 - this looks good to me.

@elasticdog - you good with us charging forward into the future? :racehorse:

elasticdog commented 11 years ago

I do think it's a good idea to update the syntax for Vagrant 1.1+, but when I test the existing Vagrantfile with Vagrant v1.1.2, it still works as expected...it just issues a warning about the config.vm.customize section being VirtualBox-specific. Were you seeing a different failure?

I just wanted to verify with you before merging in the changes, but this looks great.

phinze commented 11 years ago

Yeah Vagrant 1.1.x maintains backwards compatibility with old-style Vagrantfiles, but it yells at you every time it loads them. I didn't see failures when I used it - just the warnings.

It would be nice to be able to maintain compatibility with both, but I think the effort (and code) required to do so is not really worth it. So my vote would just be to go for it. :zap:

elasticdog commented 11 years ago

@phinze Sounds good..I appreciate you verifying that it was just the warnings.

@ganguera These changes have been merged. Thank you for the contribution!