Closed ljm42 closed 2 years ago
I would like to move the transcrypt password out of the git config file and come up with some other method of storing it.
I'm wondering if you'd be open to creating functions for get_password() and set_password(), something like this:
get_password()
set_password()
get_password() { local password=$(git config --get --local transcrypt.password) echo "$password" } set_password() { local password=$1 git config transcrypt.password "$password" }
the code would call those like this:
current_password=$(get_password) set_password "$password"
Then in my implementation I would just have to modify those functions and not all the places that get/set the password. Would you be open to that?
Oh, with these names the current get_password() would have to be renamed, maybe get_password_from_user() ?
get_password_from_user()
Solved with new load_password() and save_password() functions merged from #142, thanks for the improvement!
load_password()
save_password()
I would like to move the transcrypt password out of the git config file and come up with some other method of storing it.
I'm wondering if you'd be open to creating functions for
get_password()
andset_password()
, something like this:the code would call those like this:
Then in my implementation I would just have to modify those functions and not all the places that get/set the password. Would you be open to that?
Oh, with these names the current
get_password()
would have to be renamed, maybeget_password_from_user()
?