search

elasticdog / transcrypt

transparently encrypt files within a git repository
MIT License
1.43k stars 102 forks source link

create functions for get_password() and set_password() #142

Closed ljm42 closed 2 years ago

ljm42 commented 2 years ago

This makes it easier to override password handling locally See #141

jmurty commented 2 years ago

Hi @ljm42 I like this change thanks, but I think it could be even clearer if the new functions could be called load_password() and save_password() instead of using the get/set prefixes. This would also remove the need to rename the existing get_password() function to get_password_from_user()

What do you think?

ljm42 commented 2 years ago

Great idea! Can you squash these to a single commit? Or I could create a new PR on a clean branch if you'd like?

jmurty commented 2 years ago

It’s fine to make changes on this branch. I’ll squash at merge time

ljm42 commented 2 years ago

Perfect. This should be good unless you see other issues