rekeying broken in 2.3.0-pre

elasticdog / transcrypt

transparently encrypt files within a git repository

MIT License

1.46k stars 102 forks source link

rekeying broken in 2.3.0-pre #159

Closed wpbrown closed 1 year ago

wpbrown commented 1 year ago

Attempting to rekey always result in an error that repository is already configured.

You are about to re-encrypt all encrypted files using new credentials.
Once you do this, their historical diffs will no longer display in plain text.

Proceed with rekey? [y/N] y

transcrypt: the current repository is already configured; see 'transcrypt --display'

jmurty commented 1 year ago

Hi @wpbrown I haven't been able to reproduce this problem on Mac OS Ventura 13.2.1 or Ubuntu 23.04

Which versions of the following are you using

Platform and version (e.g. Mac Ventura, Linux Ubuntu, etc)?
Transcrypt version installed in the repository
./.git/crypt/transcrypt --version
Path Transcrypt will use for the openssl command
git config transcrypt.openssl-path
Exact version of the openssl command used by Transcrypt
E.g. openssl version

wpbrown commented 1 year ago

@jmurty Sorry about that. It was a late night. I saw "Merge Release 2.2.3" and grabbed the wrong commit hash. This is 2.3.0-pre that is affected (commit 605d9d0). It looks related to the context changes. 2.2.3 is working.

Steps are simply

git clone git@github.com:XXX repo
cd repo
transcrypt -c aes-256-cbc -p XXX
transcrypt -r

jmurty commented 1 year ago

Thanks for confirming that.

I'm glad the main release isn't broken, and it's great to have the problem caught early on the latest main branch. I need to plug that hole in our tests.

jmurty commented 1 year ago

Hi @wpbrown the rekey bug should now be fixed on main as of commit c505199e080f2cd75bf20f96a13c1ad24d6b31bb