search

elasticdog / transcrypt

transparently encrypt files within a git repository
MIT License
1.46k stars 102 forks source link

Fix #166 #167

Closed dimitrov-adrian closed 1 year ago

dimitrov-adrian commented 1 year ago

Disable colors when doing grep

jmurty commented 1 year ago

Hi @dimitrov-adrian thanks for this PR but I'm reluctant to add --color=never to grep commands because although that flag works for GNU GREP, it may not be supported on all platforms and could break for some users. Also, if the grep command needs to have --color=never added in this place, there are a few other uses where it will have the same problem.

Is there a safer way to disable grep colour output that doesn't assume the --color flag is always supported, perhaps by setting an environment variable?

If we can find a risk-free way of disabling color output I'd be happy to merge that, but the best fix might be to change the way you have grep colouring set up per my update on issue #166

jmurty commented 1 year ago

Fixed with alternative approach in commit a825f9de0b16084b5e279cf9deaba23ade333b85