Fix realpath implementation

elasticdog / transcrypt

transparently encrypt files within a git repository

MIT License

1.46k stars 102 forks source link

Fix realpath implementation #38

Closed ssiegel closed 7 years ago

ssiegel commented 7 years ago

The previous implementation wrongly returned the current directory

for some existing inputs, e.g. "/" or "/etc",
for some not existing inputs, e.g. "/no_such_name/" or "/etc/no_such_name/" or "no_such_name/",
for the empty string.

The latter made the safety check for an existing git repository always pass, leading to a bunch of errors when run outside of a repository.

elasticdog commented 7 years ago

Thank you very much for fixing this! I really appreciate the contribution and am thinking I need to get some testing into place as more and more transcrypt functionality gets added. I've already merged your code into master and am currently traveling, but will try and cut a new release when I have some downtime.