elasticio / code-component

The holy grail of the elastic.io platform
Apache License 2.0
2 stars 12 forks source link

Passing the same params to the run function, as Sailor passes #27

Closed pnedelko closed 4 years ago

pnedelko commented 4 years ago

Before this change the run function received only msg argument. Now it receives cfg and snapshot as well.

cfg is not particularly useful, anyway. It just contains 1 property: code.

The reason is to make it as close as possible to the real process function. With this change this component now will be able to work with snapshots.

jhorbulyk commented 4 years ago

Solves #20 and comes close to solving #21 but not quite.

pnedelko commented 4 years ago

@jhorbulyk btw I did this PR to debug a credentials support in OIH (#21). There I just able to specify the credentials_id and get my credentials in the cfg argument.