search

elasticio / jsonata-transform-component

Dedicated data transformation component for elastic.io platform based on JSONata
Apache License 2.0
3 stars 5 forks source link

Add checkbox for splitting arrays #13

Closed hannah-bulmer closed 5 years ago

hannah-bulmer commented 5 years ago

Solves issue https://github.com/elasticio/jsonata-transform-component/issues/12

Selecting the checkbox leaves array values as-is:

image image

While deselecting it makes the array contents individual values:

image

dvd-z commented 5 years ago

I will need to update my PR with the dontSplitArray option and tests as well

jhorbulyk commented 5 years ago

@dvd-z The idea is that the dontSplitArray option is an option that is specific to this component (JSONata transform component) so it shouldn't exist in your library changes.

hannah-bulmer commented 5 years ago

Once @dvd-z 's PR to move mapping logic to a library is published and merged (elasticio/component-commons-library#6), can you pull in and use that code in this component?

Yeaa will do!

jhorbulyk commented 5 years ago

Based on a previous discussion ofline, we will hold of merging this PR until we address the arrays & passthrough issue.

hannah-bulmer commented 5 years ago

Closing this for now while it is still blocked