Error message is shown in Action: Query after retrieve sample try when object is not found

[stas-fomenko]

Description: Error message Error! Sorry! The component did not provide any sample data. is shown in Action: Query after retrieve sample try when object is not found

Preconditions: Use PS Salesforce creds

STR:

1. Create flow Timer -> SF
2. Choose Action: Query in SF.
3. Input query that will not find any object (for example: "SELECT ID, Name from Contact where Name like 'tttt%'" )
4. Click on "Retrieve Sample" button
5. See error message.

AR: Error message Error! Sorry! The component did not provide any sample data. is shown in Action: Query after retrieve sample try when object is not found

ER: When Lookup failed (we were not able to find any parent object), In this case Lookup action should emit a single message with empty body.

[jhorbulyk]

When Lookup failed (we were not able to find any parent object), In this case Lookup action should emit a single message with empty body.

I'm not sure if I agree with this approach. Based on the Component Behavoir Standards, there are cases when components would work correctly and not emit any data. I think that in this case, the salesforce component is working correctly but we should perhaps write up a platform issue so that our UI messaging is clearer and responds faster.

[stas-fomenko]

@jhorbulyk yea, I pasted it from here, but actually missed date of comment: 20 Nov 2017, what was much before our components meetings. @zubairov what do you think? ☝️ what do we want component to do if query did not find any object?

[jhorbulyk]

Related to component standards, the Lookup Objects (plural) action describes the concept of fetchAll mode vs emitIndividually mode. (It also describes fetchPage that likely isn't applicable to this case). It may make sense to add these two modes to the action which will then have a clearer definition for the no matching results case.

[A3a3e1]

It is a not standardized Query action. Not a standardized Lookup

[jhorbulyk]

It is a not standardized Query action. Not a standardized Lookup

@A3a3e1 Correct. The idea is applicable right?

[stas-fomenko]

fix may be implemented as in Exact-Online-component -> Action: Lookup Objects

[stas-fomenko]

DoD

Component development prerequisites:

• [x] Development team has all needed requirements
• [x] Access to the needed service with all needed permissions is granted
• [x] No open tasks that could block Component development process
• [x] The E.io’s GitHub repository must be checked if there is another implementation of the component under development. If it exists, new repository should not be created
• [x] Component architecture should be discussed and approved before start coding

Development:

• [x] Code is written and formatted in accordance with the Styling guide
• [x] Code (incl. configs, test samples, environment variables etc.) MUST NOT contain any sensitive data like passwords, tokens, API keys etc.
• [x] Component logs does not contain any sensitive data (credentials, input/output requests, Environment variables)
• [x] Code is covered with unit tests
• [x] Component code is covered with integration tests (optional)
• [x] Triggers/actions comply with OIH patterns
• [x] Documentation (README.md file in the Github) is 100% ready
• [ ] CI is set up
• [x] All development branches are reviewed

After QA:

• [ ] All development branches are merged into master branch
• [ ] Sprint review preparation is finished (demo flow is built)

QA:

• [x] Test cases for the component are ready at the TestRail
• [x] Functional testing is finished
• [x] Regression testing is finished (optional)
• [x] Component is deployed to the production stage (app.elastic.io) and/or other required stage
  • Component has a proper access level
  • Smoke test is finished
• [x] Release notes are done
• [x] Component Roadmap is updated
• [x] Component spreadsheet is updated