elasticio / xml-component

Component to parse, validate, generate XML data & attachments for elastic.io platform
Other
0 stars 5 forks source link

Component should support larger attachments #51

Closed jhorbulyk closed 1 year ago

jhorbulyk commented 2 years ago

Other Feature Request

Description

Currently, the component code blocks writing of attachments that are larger than 5MB in size in certain branches and does not appear to enforce limits in other branches. (https://github.com/elasticio/xml-component/blob/b9b136900b8918be8dcc639c58d279a3302ed38b/lib/actions/attachmentToJson.js#L8) We should apply a constant max size limit to all files. This limit should default to 100MB (100 1024 1024 bytes) however it should be configurable via a MAX_FILE_SIZE env variable. We should ensure that all Code paths can hande files that are close to this limit.

Definition of Done

if0s commented 1 year ago

@andrewreshitko component can work with up to 10MB files, to support bigger files, we need to change main library and modify actions (ex. attachmentXML-attachmentJSON and backward)

HannaTrotsenko commented 1 year ago

https://github.com/elasticio/xml-component/releases/tag/1.4.0