Closed cristiklein closed 2 weeks ago
I saw that there are still a few uses of ck8s
in the schema, should those perhaps also be changed?
I saw that there are still a few uses of
ck8s
in the schema, should those perhaps also be changed?
Good point! I only found one instance of ck8s
in prose. When and how to change code (which includes config key changes) is out-of-scope for this migration and needs to be determined later.
I saw that there are still a few uses of
ck8s
in the schema, should those perhaps also be changed?Good point! I only found one instance of
ck8s
in prose. When and how to change code (which includes config key changes) is out-of-scope for this migration and needs to be determined later.
Maybe this example too? Otherwise LGTM
I saw that there are still a few uses of
ck8s
in the schema, should those perhaps also be changed?Good point! I only found one instance of
ck8s
in prose. When and how to change code (which includes config key changes) is out-of-scope for this migration and needs to be determined later.Maybe this example too? Otherwise LGTM
Thanks for catching this too! Didn't realize that changing example values is safe too.
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
What does this PR do / why do we need this PR?
The https://elastisys.io website was recently rebranded to Welkin. Some part of that website are generated from Apps configuration documentation. Therefore this PR rebrands those part of Apps which end up on https://elastisys.io.
Note that, rebranding the source code is out-of-scope of that migration project and is a decision-to-be-taken.
Information to reviewers
Checklist
NetworkPolicy Dashboard