elastisys / compliantkubernetes-apps

Elastisys Compliant Kubernetes is an open source, Certified Kubernetes distribution designed according to the ISO27001 controls: providing you with security tooling and observability from day one.
https://elastisys.io/compliantkubernetes/
Apache License 2.0
46 stars 8 forks source link

Rebrand to Welkin in configuration documentation #2334

Closed cristiklein closed 2 weeks ago

cristiklein commented 2 weeks ago

[!warning] This is a public repository, ensure not to disclose:

  • [x] personal data beyond what is necessary for interacting with this pull request, nor
  • [x] business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

Optional: Mark one or more of the following that are applicable:

[!important] Breaking changes should be marked kind/admin-change or kind/dev-change depending on type Critical security fixes should be marked with kind/security

What does this PR do / why do we need this PR?

The https://elastisys.io website was recently rebranded to Welkin. Some part of that website are generated from Apps configuration documentation. Therefore this PR rebrands those part of Apps which end up on https://elastisys.io.

Note that, rebranding the source code is out-of-scope of that migration project and is a decision-to-be-taken.

Information to reviewers

Checklist

lunkan93 commented 2 weeks ago

I saw that there are still a few uses of ck8s in the schema, should those perhaps also be changed?

cristiklein commented 2 weeks ago

I saw that there are still a few uses of ck8s in the schema, should those perhaps also be changed?

Good point! I only found one instance of ck8s in prose. When and how to change code (which includes config key changes) is out-of-scope for this migration and needs to be determined later.

lunkan93 commented 2 weeks ago

I saw that there are still a few uses of ck8s in the schema, should those perhaps also be changed?

Good point! I only found one instance of ck8s in prose. When and how to change code (which includes config key changes) is out-of-scope for this migration and needs to be determined later.

Maybe this example too? Otherwise LGTM

cristiklein commented 2 weeks ago

I saw that there are still a few uses of ck8s in the schema, should those perhaps also be changed?

Good point! I only found one instance of ck8s in prose. When and how to change code (which includes config key changes) is out-of-scope for this migration and needs to be determined later.

Maybe this example too? Otherwise LGTM

Thanks for catching this too! Didn't realize that changing example values is safe too.