elastisys / compliantkubernetes-kubespray

Apache License 2.0
28 stars 7 forks source link

Managed upgrade script #309

Closed ayoub-eddafali closed 9 months ago

ayoub-eddafali commented 1 year ago

What kind of PR is this?

Required: Mark one of the following that is applicable:

Optional: Mark one or more of the following that are applicable:

[!important] Critical security fixes should be marked with kind/security Breaking changes should be marked kind/admin-change or kind/dev-change depending on type

Platform Administrator notice

What does this PR do / why do we need this PR?

Managed upgrade script

Additional information to reviewers

Screenshots

Checklist

aarnq commented 1 year ago

Would it be possible to use ansible-inventory -i inventory.ini --list instead to get all required information from the main inventory? It would be able to handle generated inventories as we have with OpenStack environments, and also make it easier to parse and manage as it outputs in JSON so you can easily list groups and hosts.

aarnq commented 1 year ago

Nit: Do try to fix the pre-commit issues, and usually with the code style we use function names should be snake_case.

aarnq commented 11 months ago

Would it be possible to use ansible-inventory -i inventory.ini --list instead to get all required information from the main inventory? It would be able to handle generated inventories as we have with OpenStack environments, and also make it easier to parse and manage as it outputs in JSON so you can easily list groups and hosts.

I still think this should be done within this PR to make it work with generated inventories.

ayoubeddafali commented 10 months ago

Added some fixes, and tested it again on an empty exoscale kubespray cluster, and seems to be working. Would be grateful if someone could test this on his dev cluster, or a cluster with AMSes