Force sc wc cluster names

[anders-elastisys]

What kind of PR is this?

Required: Mark one of the following that is applicable:

• [ ] kind/feature
• [ ] kind/improvement
• [ ] kind/deprecation
• [x] kind/documentation
• [ ] kind/clean-up
• [ ] kind/bug
• [ ] kind/other

Optional: Mark one or more of the following that are applicable:

[!important] Critical security fixes should be marked with kind/security Breaking changes should be marked kind/admin-change or kind/dev-change depending on type

• [x] kind/admin-change
• [ ] kind/dev-change
• [ ] kind/security
• [ ] [kind/adr]()

Platform Administrator notice

ck8s-kubespray commands no longer support using other prefixes besides sc or wc.

What does this PR do / why do we need this PR?

The compliantkubernetes-apps repo forces cluster config names to be wc and sc while the compliantkubernetes-kubespray repo has previously supported custom prefixes for cluster config. This PR helps standardize the repositories by enforcing the wc and sc cluster naming convention.

• Fixes #314

Additional information to reviewers

Screenshots

Checklist

• [x] Proper commit message prefix on all commits
• Change checks:
  • [x] The change is transparent
  • [ ] The change is disruptive
  • [ ] The change requires no migration steps
  • [ ] The change requires migration steps
• Metrics checks:
  • [ ] The metrics are still exposed and present in Grafana after the change
  • [ ] The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
  • [ ] The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
• Logs checks:
  • [ ] The logs do not show any errors after the change
• Network Policy checks:
  • [ ] Any changed pod is covered by Network Policies
  • [ ] The change does not cause any dropped packages in the NetworkPolicy Dashboard
• Pod Security Policy checks:
  • [ ] Any changed pod is covered by Pod Security Admission
  • [ ] Any changed pod is covered by Gatekeeper Pod Security Policies
  • [ ] The change does not cause any pods to be blocked by Pod Security Admission or Policies
• Falco checks:
  • [ ] The change does not cause any alerts to be generated by Falco

[anders-elastisys]

I think it would make sense to also verify that the prefix is correct here as well:

https://github.com/elastisys/compliantkubernetes-kubespray/blob/37f7386c39db2a9c806f935687ea0c42d824fd25/bin/common.bash#L8

Maybe there are other places in the code where it would also make sense.

@viktor-f I added a check in common.bash, as I see it most of the other bin scripts sources this script, hence they will all run this check. However, I noticed that common.bash runs for all scripts (since it is sourced here) and it the prefix to set different config variables. This does not really make sense for the upgrade command in its current state, as it runs for both clusters. Should this be addressed in this PR (or perhaps in this one), or should it perhaps be a separate issue? It does not really break anything as it is, its more that it doesn't entirely make sense.

[viktor-f]

I think it would make sense to also verify that the prefix is correct here as well: https://github.com/elastisys/compliantkubernetes-kubespray/blob/37f7386c39db2a9c806f935687ea0c42d824fd25/bin/common.bash#L8 Maybe there are other places in the code where it would also make sense.

@viktor-f I added a check in common.bash, as I see it most of the other bin scripts sources this script, hence they will all run this check. However, I noticed that common.bash runs for all scripts (since it is sourced here) and it the prefix to set different config variables. This does not really make sense for the upgrade command in its current state, as it runs for both clusters. Should this be addressed in this PR (or perhaps in this one), or should it perhaps be a separate issue? It does not really break anything as it is, its more that it doesn't entirely make sense.

I think it makes sense to try to fix it in this PR (but maybe after the other PR is merged). Not sure exactly how to fix it though, it would be nice if we just allow "both" for the upgrade command and then "wc/sc" for the rest.