Closed cristiklein closed 4 months ago
Looks great! Just one question: is there any way to get the "Try Managed"-button in the top right to be one of the other accent colors, or is that a horrible PitA? Ignore if it's too difficult, but if it's decent in terms of work, I think it would look nicer if it "popped" differently than the other buttons do.
Code blocks pop much much more now than they used to -- and more than the buttons, to be frank.
Could you include this image instead of the old marchitecture? Link to png: https://drive.google.com/file/d/1sudf3zFedsZi_VaPdV_-rr47OGxeBggM/view?usp=drive_link Link to svg: https://drive.google.com/file/d/1Xi-N1NwHU-GuomEKMJJoqzOqweNfv1Rl/view?usp=drive_link
After that I think we're good to go!
To answer Lars' question: we could use northern lights 3 : #FB8FFC for that button. Then I would like the text to be in Night blue : #192131
We could also make the code blocks in Sky blue (#B8D2FF) to make them pop less.
Thanks for your feedback @llarsson and @gabriellahansson1 .
To answer Lars' question: we could use northern lights 3 : #FB8FFC for that button. Then I would like the text to be in Night blue : #192131
Done, see below. I kept "hover non-brandbook green" for hover over that button. Let me know if I should change it.
We could also make the code blocks in Sky blue (#B8D2FF) to make them pop less.
Done, see below.
I'm going to approve this on technical grounds, but also ask the question: do we really need all those font files? Perhaps not all get loaded?
You're right. I removed Poppins Bold from the CSS, which I noticed is not needed by the brandbook. When it comes to storing the files themselves in Git, I prefer to keep all files though in the fonts
folder, since it feels wrong to "cut" the Poppins font.
Prio 2: Updated marchitecture
Done, see below. Note that some text was not converted into paths. This means that -- due to technical details which even I find boring -- some text didn't show in Poppins. I converted the text into paths using Inkscape. Please double-check.
Looks great to me!
⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:
Quality gates:
Adjust most typography, logos and colors to the brandbook. We decided to pick up leftovers as we discover them.
Fixes #
Some examples: