Issue 771 - Githubissues

elastisys / compliantkubernetes

Documentation for the Compliant Kubernetes project

https://elastisys.io/compliantkubernetes

Apache License 2.0

118 stars 32 forks source link

Issue 771 #910

Closed llarsson closed 2 months ago

llarsson commented 3 months ago

Implements #771

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

[x] personal data beyond what is necessary for interacting with this Pull Request;
[x] business confidential information, such as customer names.

Quality gates:

[x] I'm aware of the Contributor Guide and did my best to follow the guidelines.
[x] I'm aware of the Glossary and did my best to use those terms.

llarsson commented 3 months ago

@simonekman I understand if you don't feel like reading the whole thing as part of the review work!

For you, perhaps the focus is more on the level of whether it's a good structure to have the information presented in the navbar as follows:

llarsson commented 3 months ago

Thanks, @simonekman! Now that you mention it, I question whether we would even make this a sub-page at all. Might as well just put it on the same level as the ISO and NIST ones, right under "For CISOs and DPOs", I think.

Until we write far too many of these, and categorizing is needed, it makes sense that these that are not industry-specific are shown front and center.

Like this:

I moved the "ISA/IEC 62443" to a category called "Industrial control systems", too, by the way, because I'm not sure that even people in that industry just know "62443" by heart. 😄

simonekman commented 3 months ago

LGTM, please merge! :)

simonekman commented 2 months ago

Since CK also approved I'm merging now. Want to include a link to this in a proposal I'm working on.