elax46 / custom-brand-icons

Custom brand icons for Home Assistant
https://elax46.github.io/custom-brand-icons/
Other
784 stars 81 forks source link

Add Cowboy logo #602

Closed gurtjun closed 4 months ago

rchiileea commented 4 months ago

this wont be approved that code is way to long for a icon, our file is large already this code is 30x the size of some of the most complicated icons in the repo. please make a request instead

rchiileea commented 4 months ago

@elax46 reject this pull request icons as they are unneciserry to big for what they are.

gurtjun commented 4 months ago

this wont be approved that code is way to long for a icon, our file is large already this code is 30x the size of some of the most complicated icons in the repo. please make a request instead

Ok, I need to check how I can make them smaller…

gurtjun commented 4 months ago

@rchiileea / @elax46 I removed the IKEA one (that's indeed very large). Can you please check the Cowboy ones again? They are not as big compared to other icons.

rchiileea commented 4 months ago

@rchiileea / @elax46 I removed the IKEA one (that's indeed very large). Can you please check the Cowboy ones again? They are not as big compared to other icons.

They still seem a bit large to me for what effectively are a 30 point icon for the plain one and a 38 point one for the second. Sorry it’s just I have mad lots of icons now and I can generally tell from code if there are to many points, but a request in for both in issues, both the ikea and the cowboy I am sure I can throw something hing together for the next release

gurtjun commented 4 months ago

@rchiileea / @elax46 I removed the IKEA one (that's indeed very large). Can you please check the Cowboy ones again? They are not as big compared to other icons.

They still seem a bit large to me for what effectively are a 30 point icon for the plain one and a 38 point one for the second. Sorry it’s just I have mad lots of icons now and I can generally tell from code if there are to many points, but a request in for both in issues, both the ikea and the cowboy I am sure I can throw something hing together for the next release

Do you want me to provide the image files via issues? SVG files were generated using Inkscape (but I don't have any experience with that so must have done something wrong)

elax46 commented 4 months ago

you can open a request for new icons @rchiileea will take care of it I'll close this request

rchiileea commented 4 months ago

@rchiileea / @elax46 I removed the IKEA one (that's indeed very large). Can you please check the Cowboy ones again? They are not as big compared to other icons.

They still seem a bit large to me for what effectively are a 30 point icon for the plain one and a 38 point one for the second. Sorry it’s just I have mad lots of icons now and I can generally tell from code if there are to many points, but a request in for both in issues, both the ikea and the cowboy I am sure I can throw something hing together for the next release

Do you want me to provide the image files via issues? SVG files were generated using Inkscape (but I don't have any experience with that so must have done something wrong)

my main issue is SVG if none exists share picture, but I wont click any links in posts thanks to one person linking a svg that was on a site known for breaches... so I must see a image in the post.

https://github.com/elax46/custom-brand-icons/issues you request here, but make sure to read the guidlines for this when you do it in the future, I have added these icons for next release (redone them)

rchiileea commented 4 months ago

cowboy-ebike cowboy-ebike-alt ikea-sinnerlig

gurtjun commented 4 months ago

cowboy-ebike cowboy-ebike-alt ikea-sinnerlig

Thanks! Looks nice