search

elax46 / custom-brand-icons

Custom brand icons for Home Assistant
https://elax46.github.io/custom-brand-icons/
Other
833 stars 89 forks source link

Rangerover #674

Closed a-r-j-a-n closed 4 months ago

a-r-j-a-n commented 4 months ago

Added range rover icon

rchiileea commented 4 months ago

@a-r-j-a-n is this not the second icon you have submitted as a pull request that is wrong? Please be patient as mentioned in the refused quat one needs to be a 24x24 view box with a 2pixel bleed area around the icon.

a-r-j-a-n commented 4 months ago

I dont understand what the issue with the viewbox is for the rangerover svg.

image

Here it says the viewbox is 0 0 24. Can you please explain?

rchiileea commented 4 months ago

you deleted 150x150 and added 150 x 150, I have checked the quatt logo its fine, what are you using to create icons?

rchiileea commented 4 months ago

see this post for a discription, maybe also try not to mess up the info, but this should help you with templating issues with icons, https://github.com/elax46/custom-brand-icons/pull/665#issuecomment-2135788285

Also I would rather you clean up the range rover icon as its a bit janky (odd edges and more points than needed.

a-r-j-a-n commented 4 months ago

I was using boxy-svg.com/app for the logo's.

For now, I will not continue the Range Rover logo. Maybe later I will create one that is not so janky. This one was created using an already existing svg file with the odd edges.

I will create a new pull request only for the Quatt logo in the misc table. That's the one I need now. When I was looking at the Roku logo, this was also a single icon in a single table. That's why I created Quatt as a single brand icon, in a single table too.

rchiileea commented 4 months ago

I added the quart logo myself for next release and elax will sort it out