search

elazarg / nakdimon

Hebrew Diacritizer
https://nakdimon.org
MIT License
31 stars 7 forks source link

Create an installable pip package #19

Closed Gilthans closed 4 months ago

Gilthans commented 9 months ago

Hello, and thanks for the great tool! I was wondering if it has been considered to package this so it can be installed and used using pip or another package manager?

Would a PR be accepted creating such a process?

elazarg commented 9 months ago

I did not think it would be useful to users; if you think it is, then I would love to see a PR. Thanks!

elazarg commented 4 months ago

@Gilthans please review the current state of master. I intend to publish it on pip.

Gilthans commented 4 months ago

Can't say I'm an expert, but looks good to me! Sorry, I never did get around to it

elazarg commented 4 months ago

You can simply pip install it now, but there's still the issue of packing the model.