Feat/python package - Githubissues

thewh1teagle commented 4 months ago

Resolve https://github.com/elazarg/nakdimon/issues/22 and https://github.com/elazarg/nakdimon/issues/19

Now it's much simpler to use nakdimon in Python:

# pip install git+https://github.com/thewh1teagle/nakdimon@feat/python-package
# wget https://github.com/elazarg/nakdimon/raw/master/models/Nakdimon.h5

import nakdimon 

result = nakdimon.predict("Nakdimon.h5", "שלום עולם!")
print(result)

It will be best if you could publish pypi package without the model file as it's very heavy. Let me know if you willing to merge it, and I'll change the example pip command to point into that repo.

פְּרוֹיֶקְט מַדְהִים, תּוֹדָה!

elazarg commented 4 months ago

Thank you!

yuvalpinter commented 4 months ago

Thank you! Can you please also suggest the appropriate revision for the README instructions?

thewh1teagle commented 4 months ago

Thank you! Can you please also suggest the appropriate revision for the README instructions?

I haven't added instructions to the README yet, but I can do that. Do you mean we should add revisions to ensure stability even if the repo changes? The PR is already merged, so I can't make more modifications to it. I'll probably create another one next.

By the way, off-topic: I'm developing a TTS model in Hebrew. Could you offer some direction or insights? You can see my progress at the bottom of this GitHub issue.

yuvalpinter commented 4 months ago

I just meant for documentation, so people can know they can use the pip version. But sure, no rush.

elazarg / nakdimon

Feat/python package #23