search

elazarl / go-bindata-assetfs

Serves embedded files from `jteeuwen/go-bindata` with `net/http`
BSD 2-Clause "Simplified" License
870 stars 116 forks source link

Allows sending a custom 404 page back #43

Closed c4milo closed 8 years ago

elazarl commented 8 years ago

Why did you close the PR?

c4milo commented 8 years ago

This is a bad idea, it will return HTTP 200 status code and the only way for us to get it to return a 404 with a custom page is by wrapping ResponseWriter within a custom HTTP handler. Which is something we cannot do if using http.FileServer.