search

elazarl / goproxy

An HTTP proxy library for Go
BSD 3-Clause "New" or "Revised" License
5.89k stars 1.07k forks source link

Merge `abourget/goproxy` ?! #136

Open abourget opened 8 years ago

abourget commented 8 years ago

@elazarl wanted to know what your plan was.. I've seen quite a bit of traction in my fork.. with the radically changed API.. I remember you telling me you'd like to make it v2 or something.. are there still plans for that ?

elazarl commented 8 years ago

I certainly do, but I want to take the time and design it properly, probably learning from your fork's experience.

The design would consist of writing code sample requested by people with the new, yet to be implemented API. Something among the lines of https://www.youtube.com/watch?v=aAb7hSCtvGw

To make sure it would actually start, I'll start a sketch by this weekend in the Wiki, and would invite all stakeholders to contribute.

Does that sound like a plan?

abourget commented 8 years ago

@elazarl to be concrete.. I think we'd need to retrofit all changes since my fork that occured in your repo.. and port it to my branch.. I can do it, but maybe you could learn the ins and outs of my branch by trying to do so..

At that point, we'd have a shared understanding of where we're at, and we could flesh out where we'd go.

What do you think ?

abourget commented 8 years ago

Writing the example programs is very useful.. it would augment the documentation at the same time.

elazarl commented 8 years ago

I'll definitely have a look at the changes before starting. I already did at the time, but I need to refresh my memory.

I'll try to submit pull request to your repository at the process.

JensRantil commented 4 years ago

What's the status here?

@abourget Is there a list of what your fork contains which this fork doesn't?

elazarl commented 4 years ago

Unfortunately I won’t have too much time to invest in a revamp of goproxy.

On Sat, Oct 12, 2019 at 9:39 PM Jens Rantil notifications@github.com wrote:

What's the status here?

@abourget https://github.com/abourget Is there a list of what your fork contains which this fork doesn't?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/elazarl/goproxy/issues/136?email_source=notifications&email_token=AAB7RIRHRJVRZQFKEF477FDQOIKXNA5CNFSM4BWBTHZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCFZGA#issuecomment-541351064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB7RISDTLH3KQ5KWWG4MKDQOIKXNANCNFSM4BWBTHZA .