search

elazarl / goproxy

An HTTP proxy library for Go
BSD 3-Clause "New" or "Revised" License
6.06k stars 1.1k forks source link

Potential Typo in Request Handling - "r.Close" misset to False? #515

Open tiaras12 opened 1 year ago

tiaras12 commented 1 year ago

https://github.com/elazarl/goproxy/blob/3ec07828be7ac4d84b1561216ae707dc12b2739a/proxy.go#L99-L108

It seems that req.Close should set to true when the "Connection" header contains "close" according the comment above.
However, in the above snippet, r.Close is being set to false. Is this a typo or I misunderstanding it