elbamos / largeVis

An implementation of the largeVis algorithm for visualizing large, high-dimensional datasets, for R
340 stars 62 forks source link

Fix "tutorial" (typo & verbosity list issue) #18

Closed Laurae2 closed 8 years ago

Laurae2 commented 8 years ago

This PR fixes:

elbamos commented 8 years ago

@Laurae2 I'm just seeing this now. If you want to resubmit this so its against the current master, I'll accept the PR. Thanks!

Laurae2 commented 8 years ago

Rebased against master, you can squash and merge all the commits into one while merging as one of your commits was similar to mines.

It leaves all the typos "buildWijMaatrix" fixed in commits (I thought I merged all of them, seems it didn't - you should have squash and merge so it becomes only one commit at the time of merging branches).

I can squash together all the commits myself if the squash & merge is not available in this repo.

elbamos commented 8 years ago

Can you clear the CI failures? Also, could you make the pull against branch hdbscan? That's going to be 0.1.8

codecov-io commented 8 years ago

Current coverage is 75.00% (diff: 100%)

Merging #18 into hdbscan will not change coverage

@@            hdbscan        #18   diff @@
==========================================
  Files             6          6          
  Lines           264        264          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            198        198          
  Misses           66         66          
  Partials          0          0          

Powered by Codecov. Last update fcfce15...07969ba

Laurae2 commented 8 years ago

Fixed the issue making check failing and changed the pull to hdbscan as requested. Builds are passing.