search

elbeicktalat / flutter_auth_buttons

Auth Buttons is a flutter widget library, include buttons for authenticating with the most popular social networks.
https://pub.dev/packages/auth_buttons
BSD 3-Clause "New" or "Revised" License
32 stars 32 forks source link

Make methods more readable. #33

Closed elbeicktalat closed 2 years ago

elbeicktalat commented 2 years ago

I'm sure you will take a while to understand what's happening in the following method.

https://github.com/elbeicktalat/flutter_auth_buttons/blob/b8448f4fbef45ed5ec5a557db3a94e132b217423/lib/src/buttons/twitter_auth_button.dart#L40

So this does not following any kind of clean code.

elbeicktalat commented 2 years ago

Same code after fix:

https://github.com/elbeicktalat/flutter_auth_buttons/blob/83d78a6f365f1ad2fa9408ac0a2c32aa019e8c47/lib/src/buttons/twitter_auth_button.dart#L44