search

elbereth / DragonUnPACKer

Free/Open source game file resource explorer/unpacking tool made easy!
https://www.elberethzone.net/dragon-unpacker.html
177 stars 21 forks source link

dup5Main error in lstMain #30

Closed elbereth closed 8 years ago

elbereth commented 15 years ago

This error happened when I tried to open a Inno Setup .DAT file generated by any uninstaller builds it generates. Here goes the report:

____ Error report ____

From: dup5Main in lstIndex2 Exception: EAccessViolation Reporting: Access violation at address 0057655E in module 'drgunpack5.exe'. Read of address 0387D000 [09/02/2009 15:30:31]

____ More Details ____

__ Computer status: __

Windows NT v6.0 build 6001 Service Pack 1 CPU 1: Intel(R) Pentium(R) Dual CPU T2310 @ 1.46GHz CPU 2: Intel(R) Pentium(R) Dual CPU T2310 @ 1.46GHz Memory: Free=345MB / Total=892MB

Reported by: centralkong

elbereth commented 15 years ago

Screenshot of the error

Original comment by: centralkong

elbereth commented 15 years ago

I will have a look when possible. .DAT files are handled in a quite wrong maner in Dragon UnPACKer which means it will sometimes (like in your case) open & read a file that is not in the expected format, this can of course cause problems later on.

The plan is to add some sanity checks to be sure the format was the one expected and eventually to show a popup asking if the format is from the expected game.

Original comment by: elbereth

elbereth commented 15 years ago

I too get this error, only mine occurs when I try to do anything with HPI files.

Original comment by: thedeathwalker

elbereth commented 15 years ago

From what game?

By the way .DAT files & .BIN files loading have been sanitized in v2.0.7 of the drv_default plugin.

Original comment by: elbereth

elbereth commented 15 years ago

Total Annihilation .ccx .hpi

Original comment by: thedeathwalker

elbereth commented 15 years ago

When I open rev31.gp3 (the hpi file with everything from 3.1 patch) I get indeed errors. Seems to be entries that are not compressed with LZ77 do not work correctly but I don't why. I will add a check in Dragon UnPACKer to avoid the uncatched exception but the extraction of the file format needs also to be fixed.

Original comment by: elbereth

elbereth commented 15 years ago

Well actually I just found the bug and fixed it (I was freeing the stream too early when compression was Zlib)... Fix is commited to CVS and in v2.0.7a of drv_default.

I will add the exception catching to Dragon UnPACKer later. :)

Original comment by: elbereth