Closed mattdowle closed 3 years ago
Thanks for the PR! Bit sloppy, that test, on my part. Will merge right away, and hopefully do a CRAN release soon.
Thanks again. Just to give you a heads up that we might release v1.14.0 sooner than anticipated due to https://github.com/Rdatatable/data.table/pull/4894. In recent months we've noticed that CRAN have been giving just 2 weeks notice to packages in error status, otherwise the package is removed from CRAN. When I submit to CRAN I'll just say I've communicated with you, as per CRAN policy, and it won't hold up release. But then you'll probably only have 2 weeks to update otherwise your package will be removed from CRAN. Not my rules or policy, just so you were fully aware. Hope ok.
0.5.0 is now published on CRAN
Perfect. Thank you!
Adjustment to the test to cope if
aggregate()
returns the groups in a different order. The addedmatch()
ensures that the result for each group is compared without an assumption that thenew
andold
result has the groups in the same order.With the current dev version of data.table 1.13.7 (to be released as 1.13.8), news item 2 is :
which affects the
fintersect()
calls increate_common_data()
. The first call affected being https://github.com/elbersb/segregation/blob/master/R/ipf.R#L93. Eventually the test receivesnew
andold
containing the correct group results as before, but in a slightly different order, as follows.This was highlighted by revdep testing of data.table in dev, https://github.com/elbersb/segregation/issues/5. Linking to the revdep status tracking issue, https://github.com/Rdatatable/data.table/issues/4866. Linking to the change to
data.table::fintersect()
, https://github.com/Rdatatable/data.table/issues/4716.If it looks ok to you, there's no rush at all but when you have a chance could you merge and publish to CRAN please. Otherwise
data.table
will breaksegregation
's tests on CRAN on the next update. Thanks! I checked that with this PR,segregation
passesR CMD check
with both current release ofdata.table
(1.13.6), and the dev version (so you don't need to wait for the new version to be released).