search

elboletaire / password-strength-meter

:key: A password strength meter for jQuery
https://elboletaire.github.io/password-strength-meter/
GNU General Public License v3.0
107 stars 45 forks source link

Fix testing #13

Closed elboletaire closed 5 years ago

elboletaire commented 6 years ago

Right now, saucelabs browsers testing is failing due to an unknown reason.

I need to check this further and try to fix it, or search for an alternative to saucelabs.

elboletaire commented 5 years ago

It's weird.. I'm thinking in removing the saucelabs integration, although it's cool... it gives random errors. When I created this issue it was just failing; taking a look to the saucelabs page didn't show any record and taking a look at travis builds basically showed you all the saucelabs stuff crashing.

Now it works, but some browsers fail... maybe I'll just remove those failing browsers.. dunno

jhoover4 commented 5 years ago

Whats failing? All the tests run fine for me.

elboletaire commented 5 years ago

Sorry didn't see this @jhoover4. The problem was with saucelabs integration, which was working from time to time. I've ended up replacing all the karma + istanbul + jasmine (+ the jasmine jquery plugin and other dependencies) stack with just Jest.

About the saucelabs integration... I've ended up removing it. They only store data for a few days, which makes the badge to fail + there were tests failing under some of the environments, when they shouldn't; so at the end I prefer not to use it.

elboletaire commented 5 years ago

Closed in 15617b7ad8984645f3f715ddb052ab149c8bbdb1