search

elboletaire / password-strength-meter

:key: A password strength meter for jQuery
https://elboletaire.github.io/password-strength-meter/
GNU General Public License v3.0
107 stars 45 forks source link

Fix colorbar to work with Bootstrap 4's input group. #31

Closed jhoover4 closed 5 years ago

jhoover4 commented 5 years ago

Addressing #3

This works with bootstrap 4 (the newest version). Might be a flaky solution, since it's hardcoded.

elboletaire commented 5 years ago

Sorry Jordan but I don't like this approach. Doing it this way you're adding a bootstrap specific feature/fix, and the option that I already said in #3 (add a new "closestSelector" option) was a more generic one.

This closestSelector option would be set as div by default, and could be set as .form-group for this use case.