Calculate color instead changing background position

elboletaire / password-strength-meter

:key: A password strength meter for jQuery

https://elboletaire.github.io/password-strength-meter/

GNU General Public License v3.0

107 stars 45 forks source link

Calculate color instead changing background position #7

Closed hmichal-dev closed 4 years ago

hmichal-dev commented 6 years ago

Add option to calculate colorbar color instead using background image.

hmichal-dev commented 6 years ago

Travis test failed due to incorrect configuration

elboletaire commented 6 years ago

Yeah apparently I broke something when writing another package. I'll try to get it fixed asap.

elboletaire commented 6 years ago

BTW, what does this feature exactly do? Allows us to not use a bg image for the progress bar?

hmichal-dev commented 6 years ago

Yes, this feature allow us to not use image as background. Background (color of progress bar) is calculated dynamically and goes from green via yellow to red. To keep backward compatibility image is used by default.

In current version image still loeds until css is overwriten by user. This can be changed by adding diffrent classes when using option useColorBarImge is false - this is a thing for future development.

elboletaire commented 5 years ago

I'd like to see this merged for v2 (which I'm currently working on), but I miss some things:

Use widget settings for things like the blue color (forced by you to 10), or for the max color (forced by you to 240).
Split the code into smaller functions.
Add a test (or tests). All that ternary operators are confusing and add a lot of cyclomatic complexity. They should, at least, be properly tested to ensure all the conditions.
There's a typo in the option varname, you spelled Imge instead of Image

jhoover4 commented 5 years ago

I'm going to get this pushed up in a new PR next with your recommendations.

jhoover4 commented 5 years ago

Alrighty, new PR for this #28

elboletaire commented 4 years ago

Superseeded by #28