elbywan / crystalline

A Language Server Protocol implementation for Crystal. 🔮
MIT License
448 stars 24 forks source link

Remove archived dependency and add --version #100

Closed hugopl closed 2 weeks ago

hugopl commented 2 weeks ago

Hi,

hugopl/version_from_shard was archived by me, so I'm replacing it by a simple macro.

It get the version from shards.yml and add a build to it with a short git hash or "unknown" if it wasn't built from a git repository (e.g. tarballs).

So version 0.15.0 is now show as 0.15.0+f8aa5c6, i.e. the build part of the version will always present. If this isn't desired I can update the PR.

Then I also add a --version flag, so neovim (and probably other editors) can show crystalline version on UI, nowadays it can't:

image

With this patch:

image

elbywan commented 2 weeks ago

Hey @hugopl :wave:

hugopl/version_from_shard was archived by me, so I'm replacing it by a simple macro.

Oh, thanks for dedicating some time to update this! :bow:

zw963 commented 2 weeks ago

Thanks, crstalline have --version now finally.