elbywan / crystalline

A Language Server Protocol implementation for Crystal. 🔮
MIT License
424 stars 21 forks source link

"textDocument/publishDiagnostics" does not respect client capabilities. #16

Closed hugopl closed 3 years ago

hugopl commented 3 years ago

Hi,

"textDocument/publishDiagnostics" notifications are being sent even if the client capabilities say not to.

A minor issue since the server can just ignore these notifications... and also because any good client must support diagnostics.

elbywan commented 3 years ago

A minor issue since the server can just ignore these notifications... and also because any good client must support diagnostics.

Yeah it's not a big deal but it's always good to stick to the specs. 👍

Closed with #17.