elbywan / crystalline

A Language Server Protocol implementation for Crystal. 🔮
MIT License
424 stars 21 forks source link

Add Crystal 1.2 support #30

Closed refi64 closed 2 years ago

refi64 commented 2 years ago

Based on #27, docker image builds locally but I guess we'll see about CI...

refi64 commented 2 years ago

Oops, looks like I forgot to make the needed changes to the macOS CI. Don't have a Mac to test it in particular, but the changes look like they should work...

refi64 commented 2 years ago

...and attempted to fix again, sorry about needing workflow approval every time :sweat_smile:

elbywan commented 2 years ago

...and attempted to fix again, sorry about needing workflow approval every time 😅

@refi64 No worries this is only clicking a button, thank you for contributing! ❤️

refi64 commented 2 years ago

Looks like it's passing now!

elbywan commented 2 years ago

This is great, thanks! ❤️

I think I can also remove the need to clone the crystal repo because of the markd dependency, I'll make a follow-up PR. Then I'll release a new version 📦.