elbywan / crystalline

A Language Server Protocol implementation for Crystal. 🔮
MIT License
436 stars 23 forks source link

Issues with HEAD and Crystal 1.6 #46

Closed ukd1 closed 1 year ago

ukd1 commented 1 year ago

On 20e585dd00352b0261b5ba3eb9e2b41a9f8fa029 (current HEAD):

crystalline % shards 
Resolving dependencies
Fetching https://github.com/hugopl/version_from_shard.git
Fetching https://github.com/spider-gazelle/priority-queue.git
Fetching https://github.com/samueleaton/sentry.git
Fetching https://github.com/spider-gazelle/bisect.git
Installing version_from_shard (1.2.4)
Installing bisect (1.2.1)
Installing priority-queue (1.0.1)
Installing sentry (0.3.2 at cd86128)
(base) russ@hilaptop crystalline % env LLVM_CONFIG=/opt/homebrew/Cellar/llvm/15.0.1/bin/llvm-config crystal build ./src/crystalline.cr  -o ./bin/crystalline --release --no-debug -Dpreview_mt
Showing last frame. Use --error-trace for full trace.

In /opt/homebrew/Cellar/crystal/1.6.0/share/crystal/src/compiler/crystal/semantic/cover.cr:7:22

 7 | getter matches : ZeroOneOrMany(Match)
                      ^------------
Error: undefined constant ZeroOneOrMany
crystalline % 

Presumably this is something todo with Crystal 1.6 and crystal-lang/crystal#12405...

elbywan commented 1 year ago

Hey @ukd1,

Thanks for reporting the issue! 👍

I just released v0.7.0 which should be compatible with crystal 1.6.0.

ukd1 commented 1 year ago

Thanks @elbywan, will pull and try 👍🏻

ukd1 commented 1 year ago

Worked fine - thanks for the fast update. FYI on M1 Max, took ~5m to compile. Will be nice if Crystal ever works on crystal-lang/crystal#657 🤷🏻

% time env LLVM_CONFIG=/opt/homebrew/Cellar/llvm@14/14.0.6/bin/llvm-config crystal build ./src/crystalline.cr --threads 10 -o ./bin/crystalline --release --no-debug -Dpreview_mt 
env LLVM_CONFIG=/opt/homebrew/Cellar/llvm@14/14.0.6/bin/llvm-config crystal    280.40s user 2.51s system 99% cpu 4:44.12 total

Build incase any other M1 folks want a 1.6 version - crystalline.v0.7.0.tar.gz