asterite
commented
1 year ago Okay, things are hooked up now but probably not in the best way (there's a bit of repetition and you have to remember to call fix_source.)
In any case I can already showcase the improvements. Take a look at this:
It's autocompleting the x. thing even though the source has a lot of missing ends.
Or this:
It's showing the hierarchy at the top (Foo -> Bar -> foo) but the source is kind of broken.
Also "Go to definition" works fine in this state.
elbywan
This is for #55, but it's just a part of it.
This PR introduces a new type,
BrokenSourceFixer. It tries to add missing "end" and closing curly braces based on the code's indentation. It assumes users will use two spaces of indentation and use the formatter so that everything is usually aligned except when they are typing an expression.The idea then would be to run this code before feeing it to the parser, if the source code is actually broken (for that we could try to parse it and if it parses fine then there's nothing to fix.)
I didn't hook up the code yet because I wasn't sure exactly where to do that.
Edit: another thing is that the fixer tries not to add new lines. In that way any code that needs parse locations will still work fine, as the fixer only adds to the end of lines.