search

elbywan / wretch

A tiny wrapper built around fetch with an intuitive syntax. :candy:
MIT License
4.83k stars 98 forks source link

Node 18 implements fetch API #174

Closed heath-freenome closed 1 year ago

heath-freenome commented 1 year ago

Update the documentation in the README appropriately now that Node 18 supports the fetch API. See this : https://dev.to/cloudx/nodejs-18-fetch-api-test-runner-module-and-more-2ckg

elbywan commented 1 year ago

Hey @heath-freenome,

Could you be a little bit more specific about which part of the readme your are referring to?

The node.js section already mentions node 18:

🥳 Starting from Node.js 18, node includes experimental fetch support. Wretch will work without installing any polyfill.

heath-freenome commented 1 year ago

@elbywan I swear I didn't see that there when I last looked. as it's a bit subtle. Might I suggest changing the Polyfills section to be Polyfills (Node < 18 only)?

And also maybe change the first sentence to read

Since the Node.js standard library prior to Node 18, ...
elbywan commented 1 year ago

Just pushed this commit, I improved the wording a bit which should make things clearer overall.

heath-freenome commented 1 year ago

Just pushed this commit, I improved the wording a bit which should make things clearer overall.

Just added a couple of suggestions to the commit.