search

elcamlost / perl-DBD-ClickHouse

Other
13 stars 7 forks source link

Add a string concatenation to _read_body() #4

Open msestak opened 8 years ago

msestak commented 8 years ago

I found that this fixes random breakage of results while selecting from a database.

Fixes issue #2

String concatenation may not be best solution for large selects because it builds large variable in memory (propose better solution if available).

hulponot commented 7 years ago

Without this fix, it's impossible to use module with large responses. This changes definitely should be on CPAN

msestak commented 7 years ago

More elegant solution is offered in this thread: http://www.perlmonks.org/?node_id=1175544 and I updated this pull request to reflect that.