dnstwist 20201022 test failure

elceef / dnstwist

Domain name permutation engine for detecting homograph phishing attacks, typo squatting, and brand impersonation

https://dnstwist.it

Apache License 2.0

4.81k stars 764 forks source link

dnstwist 20201022 test failure #117

Closed chenrui333 closed 3 years ago

chenrui333 commented 3 years ago

👋 when I tried update the source code archive for homebrew formula to use pypi source, there is some issue with the test build as shown below:

==> /usr/local/Cellar/dnstwist/20201022/bin/dnstwist -rsw --thread=1 brew.sh
Traceback (most recent call last):
  File "/usr/local/Cellar/dnstwist/20201022/libexec/bin/dnstwist", line 962, in <module>
    main()
  File "/usr/local/Cellar/dnstwist/20201022/libexec/bin/dnstwist", line 936, in main
    if whoisq.creation_date:
AttributeError: 'NoneType' object has no attribute 'creation_date'

relates to https://github.com/Homebrew/homebrew-core/pull/67654

elceef commented 3 years ago

I'm aware of this issue. It's been resolved in commit 5be920722b3bd9c25b2b6ff55704b432f84d7d4c. You can apply this fix for brew package or wait until I release new version of dnstwist (which is going to happen soon).

chenrui333 commented 3 years ago

For the PR I attached, I just updated the source, and it is still using the same version and setup.

-  url "https://github.com/elceef/dnstwist/archive/20201022.tar.gz"
-  sha256 "f1a12c013e12e7793562aadbb36577418a7eaea5d93db6d6cd02337f49b8253a"
+  url "https://files.pythonhosted.org/packages/9a/1d/93482f7850aaf59c7e703af2ae879651887ff082a79f8f672ad2ede1b8a7/dnstwist-20201022.tar.gz"
+  sha256 "b224d25d60b6d7d9be7021f52a3ece06d98b106b2974b72e5389190b1f8abc89"

chenrui333 commented 3 years ago

I see there is a new release today, let me give it a try.

chenrui333 commented 3 years ago

works well for me, thanks!