search

elceef / dnstwist

Domain name permutation engine for detecting homograph phishing attacks, typo squatting, and brand impersonation
https://dnstwist.it
Apache License 2.0
4.76k stars 761 forks source link

Create LICENSE #126

Closed epicfaace closed 3 years ago

epicfaace commented 3 years ago

Clarify that the repo is licensed under Apache 2. This license is already included in setup.py, but the standard for github repos is to include this information in a LICENSE file.

elceef commented 3 years ago

The LICENSE file has already been in the repository, just in the docs directory.

epicfaace commented 3 years ago

@elceef That's true, but it appears that GitHub doesn't automatically detect licenses that are in the docs directory. I'd suggest moving it to the root directory so that that detection works (this would help with license search, too: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/licensing-a-repository#searching-github-by-license-type).

For example, a repo with a LICENSE file at the root looks like this (https://github.com/rjsf-team/react-jsonschema-form):

image

Whereas the license type is not detected for dnstwist:

image

epicfaace commented 3 years ago

What do you think? If you're good with moving the license to the root directory, happy to make a PR that does that.