search

elceef / dnstwist

Domain name permutation engine for detecting homograph phishing attacks, typo squatting, and brand impersonation
https://dnstwist.it
Apache License 2.0
4.76k stars 760 forks source link

removed a default mutable argument pitfall #132

Closed NaelsonDouglas closed 2 years ago

NaelsonDouglas commented 2 years ago

The problem In Python it usually dangerous to use mutable arguments like dicts or lists as default arguments in methods, as is better explained here

the solution This PR applies a simple refactoring to remove a case where a method was created using default a mutable argument

elceef commented 2 years ago

This issue does not apply, as none of the functions modify or change the data referenced by its arguments.