make it compatible with 3.6

elceef / dnstwist

Domain name permutation engine for detecting homograph phishing attacks, typo squatting, and brand impersonation

https://dnstwist.it

Apache License 2.0

4.76k stars 760 forks source link

make it compatible with 3.6 #139

Closed nurettin closed 2 years ago

nurettin commented 2 years ago

str.isascii is from python 3.7

semsaksoy commented 2 years ago

yes it is very important

elceef commented 2 years ago

Thank you for reporting this issue. After reviewing your code, I found out it actually breaks the functionality due to a typo - underscore in def is_ascii(s):. I decided to resolve this with a completely different approach. Commits 6f59e755b8bbe03dffad4c73cb286da2631f6aab, 3f3d25d8410d0a2baeb47e1400b4942825ee1a25 and 7d65e088e01f690cbd80b56b42cf7db216a42b9a should make it compatible with Python 3.5 back again.