elceef / dnstwist

Domain name permutation engine for detecting homograph phishing attacks, typo squatting, and brand impersonation
https://dnstwist.it
Apache License 2.0
4.76k stars 761 forks source link

GeoIP is depricated, replaced by geoip2 #145

Closed HenkPoley closed 2 years ago

HenkPoley commented 2 years ago

GeoIP is 'End of Life'.

Replacement is geoip2.

I wouldn't have mentioned it if GeoIP would actually still pip install on my system. I do not particularly need it. But new installs will see this angry red backtrace from pip, and wonder what's broken.

"We are planning to retire the GeoIP Legacy databases at the end of May 2022."

https://blog.maxmind.com/2020/06/retirement-of-geoip-legacy-downloadable-databases-in-may-2022

elceef commented 2 years ago

Both GeoIP Legacy and geoip2 are supported. GeoIP Legacy has been sort of preferred because unlike geoip2, the database file is included in Debian packages (and probably other Linux distributions too).

HenkPoley commented 2 years ago

Ah I see. Do note that pip install GeoIP (from requirements.txt) gives an error under Windows 11:

PS C:\Users\user> pip install GeoIP
Collecting GeoIP
  Using cached GeoIP-1.3.2.tar.gz (20 kB)
  Preparing metadata (setup.py) ... done
Using legacy 'setup.py install' for GeoIP, since package 'wheel' is not installed.
Installing collected packages: GeoIP
  Running setup.py install for GeoIP ... error
  error: subprocess-exited-with-error

  × Running setup.py install for GeoIP did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      C:\Py310\lib\distutils\dist.py:274: UserWarning: Unknown distribution option: 'bugtrack_url'
        warnings.warn(msg)
      Warning: 'classifiers' should be a list, got type 'tuple'
      running install
      running build
      running build_ext
      building 'GeoIP' extension
      creating build
      creating build\temp.win-amd64-3.10
      creating build\temp.win-amd64-3.10\Release
      D:\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.31.31103\bin\HostX86\x64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -IC:\Python310\include -IC:\Python310\Include -ID:\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.31.31103\include -ID:\Windows Kits\10\include\10.0.22000.0\ucrt -ID:\Windows Kits\10\\include\10.0.22000.0\\shared -ID:\Windows Kits\10\\include\10.0.22000.0\\um -ID:\Windows Kits\10\\include\10.0.22000.0\\winrt -ID:\Windows Kits\10\\include\10.0.22000.0\\cppwinrt /Tcpy_GeoIP.c /Fobuild\temp.win-amd64-3.10\Release\py_GeoIP.obj
      py_GeoIP.c
      py_GeoIP.c(23): fatal error C1083: Cannot open include file: 'GeoIP.h': No such file or directory
      error: command 'D:\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.31.31103\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> GeoIP

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.
elceef commented 2 years ago

I haven't noticed since Windows isn't my daily platform. Considering the most recent release of GeoIP dates back to 2014 and the "end of life" announcement, I would not expect this to be fixed.