Updated Dockerfile, ~42% reduction in image size

elceef / dnstwist

Domain name permutation engine for detecting homograph phishing attacks, typo squatting, and brand impersonation

https://dnstwist.it

Apache License 2.0

4.81k stars 764 forks source link

Updated Dockerfile, ~42% reduction in image size #77

Closed prashant-shahi closed 5 years ago

prashant-shahi commented 5 years ago

In Dockerfile, changed the base image from Ubuntu to Alpine
Huge reduction in the docker image size ~42%
Added instruction in README file to build the image locally and running

prashant-shahi commented 5 years ago

Let me know if you require any changes.

elceef commented 5 years ago

Duplicate of #65.

prashant-shahi commented 5 years ago

@elceef Nope, it's not a duplicate.

base image	size	remark
ubuntu:16.04	200MB	Previous one - before this PR was submitted
ubuntu:18.10	158MB	Current one - after this PR was Closed
python:2.7.16-alpine	83.4MB	Using Dockerfile from this PR

prashant-shahi commented 5 years ago

@elceef It rather seems that you don't really care about the project, but doing it just for the sake of doing it.

At least, check out the PRs properly, considering that the time spent by people on creating their PRs on supposedly YOUR project.

elceef commented 5 years ago

Thank you for your contribution. Although dnstwist is backward compatible with Python2, one of the main goal is to develop it using Python3. I'm a big fan of optimisation in general, however considering the fact Debian/Ubuntu Linux is main development platform, I prefer using Ubuntu docker image which also should provide quicker build time. I realise you are not satisfied that your PR was rejected. I encourage you to share your work on Docker Hub instead.