elchininet / custom-sidebar

Custom HACS plugin that allows you to personalise the Home Assistant's sidebar per user or device basis
Apache License 2.0
60 stars 4 forks source link

Get the Playwright version from the package.json #135

Closed elchininet closed 1 month ago

elchininet commented 1 month ago

To run the end-to-end tests we execute Playwright using a spcific Docker tag. To know the docker tag that we need to use, we read the Playwright Docker image tag from a file placed in the root of the project. This provokes that everytime @dependabot creates a pull request updating the @playwright/test package, tests fail because the Playwright Docker image is outdated.

In this pull request, we read the Playwright version from the same package.json and in this way, we can remove the necessity of having the .playwright_docker_version at all.

coveralls commented 1 month ago

Coverage Status

coverage: 99.735%. remained the same when pulling 8b064795ac1497605aa23e9c9fedf6d88cba515f on get_playwright_version_from_package_json into 5281dc0e86480789f1b3d76f55936caa458d9a01 on master.