Production settings - Githubissues

EmanueleMinotto commented 9 years ago

Q	A
Fixed Tickets	#582

mmoreram commented 9 years ago

Some tips here:

[x] Check the command elcodi:install and change the schema commands in favor of these new ones
[x] Check the style of this PR - You'll find some help at the end of the comment
[x] Remember to squash all commits in one to make sure that a cherry-pick is available
[x] Check the dependencies version scope
[x] As long as you finish this, please open an issue in Docs to add a cookbook about how migrations can be done

For the code style:

php bin/php-cs-fixer fix src/
php bin/php-formatter f:h:f src/
php bin/php-formatter f:u:s src/

We should append this information in chapter of How to make a PR in Elcodi

Thanks :dancers:

EmanueleMinotto commented 9 years ago

Ouch... you're right, was a really bad formed PR :\ Thank you for the fast reply, I'll fix them asap!

mmoreram commented 9 years ago

@EmanueleMinotto Amazing man! I will merge this tomorrow!

BTW, will you be in Paris?

EmanueleMinotto commented 9 years ago

sadly I can't :( but I'll follow every possible stream for sure

mmoreram commented 9 years ago

Perfect, merging!

Thanks @EmanueleMinotto

elcodi / bamboo