search

elcorto / psweep

Loop like a pro, make parameter studies fun.
https://elcorto.github.io/psweep
BSD 3-Clause "New" or "Revised" License
13 stars 2 forks source link

Consider dropping `_pset_seq` in favor of `df.index` #7

Closed elcorto closed 9 months ago

elcorto commented 2 years ago

Now that we have an int index, we may drop _pset_seq as this is the same as df.index. _pset_seq is set to NaN for parallel runs in run_local() because of random execution order (there's a not too complicated fix, but we didn't have the use case), which is not ideal. So far its only real use case is in prep_batch(), where we use it to enumerate psets in run_{machine.name}.sh, but also only in a comment as a convenience feature.

elcorto commented 9 months ago

While redundant, might be still ok to have it since we can't access df.index when passing a pset to worker().