search

eldang / Washington-HB-finder

Enter a Washington HB number and get info & a comment form in one click
GNU General Public License v3.0
5 stars 2 forks source link

Falls foul of Chrome's and IE's popup blocking #4

Open eldang opened 7 years ago

eldang commented 7 years ago

Is there a way to make this not need the user to explicitly allow popups?

nein09 commented 7 years ago

Here's an idea for this: http://stackoverflow.com/questions/18885676/open-new-tab-without-popup-blocker-after-ajax-call-on-user-click

eldang commented 7 years ago

Iiiinteresting. I initially put the timeouts in because of a different stackoverflow thread suggesting that making the calls asynchronous and out of sync with each other would get around popup blocking, but I never actually tested the simplest possible version: what if I just take the timeouts out altogether? I'll experiment with the simplest possible way first, though it may be worth bringing AJAX in anyway to better handle wrong HB numbers.

nein09 commented 7 years ago

You're welcome to assign me this because I'm going to try and fix it now.

nein09 commented 7 years ago

upon investigation, I can only open one browser tab with the technique I linked to there, not 4 or 5 of them. I think that hosting a bunch of stuff in an iframe, or scraping the text using an ajax call and response might get us further.