Revisions requested by BHS (MRS)

eldang / ballard-4culture

A webmap of the history of the residents of Old Ballard, funded by the King County 4Culture grant program.

0 stars 0 forks source link

Revisions requested by BHS (MRS) #15

Open coregis opened 2 years ago

coregis commented 2 years ago

[x] Fix floating title div in sidebar
[x] Show the place names from Column F instead of the street address; where there is no place name, copy over the address, but strip out the City, State, and Zip
[x] Make Contact link to the contact page, make the logo the link to the BHS website, and remove the link from the "Ballard Historical Society" text
[x] Make name of the active tab bold in popup
[x] Troubleshoot why Ted & Ruth Peterson are only showing up in 3 of 4 places
[ ] Schedule time with Jim Rosemary to transfer all files to BHS server

eldang commented 2 years ago

I'm adding myself to the assignees for this because I think I will need to modify the datasync script to get column F into places.geojson before you can do the second item.

I think the Ted & Ruth Peterson issue may also be one for me. I had a look at the two JSON files and the IDs are all present & correct, but I suspect this must be a bug in the code I added in https://github.com/eldang/ballard-4culture/pull/13

coregis commented 2 years ago

@eldang I'm mostly done with these changes, however I cannot figure out how to make the name of the person in the active tab have a larger font weight. I feel like it should be possible by modifying the interaction states in jquery-ui.css (starting at line 172) but there appears to be some strangeness happening between mapbox and jquery, the source of which eludes me. My goal is to make the name in the active tab have a font-weight of 800.

eldang commented 2 years ago

@coregis In theory, anything that's defined in jquery-ui.css should also be overrideable in our own CSS files (which is safer because we won't lose the change if we update the jquery-ui dependency in future). But I do find CSS precedence rules endlessly confusing, it's not just you. If you feel like you've tried everything you can think of, or just want to cut your losses, please add this to the list in https://github.com/eldang/ballard-4culture/issues/16 just to make sure I don't forget it, and I'll take a look next week.